Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load all contract transaction #917

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Feb 27, 2023

Description

Fix a bug where all the smart contract call where not reloaded when a node bootstrap.
Also start a Worker only if the node is storage node of the transaction

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working smart contracts Involve smart contracts bootstrap labels Feb 27, 2023
@apoorv-2204
Copy link
Contributor

👍

Copy link
Member

@bchamagne bchamagne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the scenario I tested:

  1. Start node A
  2. Create a SC
  3. Start node B
  4. Start node C
  5. Wait until they both are authorized
  6. Trigger SC ✔️
  7. Stop node A
  8. Trigger SC ✔️
  9. Stop node B
  10. Trigger SC ✔️
  11. Restart node C
  12. Trigger SC ✔️

Looks good to me

@samuelmanzanera samuelmanzanera merged commit ca0fd33 into archethic-foundation:develop Mar 1, 2023
@Neylix Neylix deleted the Load-all-contract-transaction branch March 1, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bootstrap bug Something isn't working smart contracts Involve smart contracts
Projects
Status: Done 🍻
Development

Successfully merging this pull request may close these issues.

None yet

5 participants